Update structured cloning for recent changes to HTML #1108
Conversation
|
@henbos @martinthomson can you take a look? |
webrtc.html
Outdated
| @@ -1321,7 +1328,7 @@ | |||
| objects.</p> | |||
| <div> | |||
| <pre class="idl"> | |||
| [ Constructor (optional RTCConfiguration configuration)] | |||
| [ Serializable, Constructor (optional RTCConfiguration configuration)] | |||
There was a problem hiding this comment.
It's the RTCCertificate that is Serializable, not the RTCPeerConnection?
domenic
force-pushed
the
update-structured-clone
branch
from
6ecfa8d to
ad9ca76
Compare
|
Thanks, fixed! |
|
LGTM. |
|
@domenic : this PR was merged and then reverted via #1171. The reason for reverting was purely that we got pushback for referencing whatwg html (something we did already before, but it was detected now), and thus we reverted and referenced w3c html. I think everyone likes the new way to do "Safe passing of structured data" better, and I've raised an Issue on the html (5.2) spec (w3c/html#898) to introduce it in the w3c version. |
|
Welp, if there's a conflict between technical excellence and bureacracy, I can't help you there. I tried my best. |
|
We're grateful for that, and hope we can sort out the bureaucracy soon! |
Fixes #1089.
It'd be good for someone with domain knowledge that this makes sense as defined for the internal slots.